| Poem: Submit | Random | Best | Worst | Recent | Comments |
|
Suggestion:
-=Dark_Angel=-, P.I. @ 81.153.196.50
|
7-Feb-05/7:35 AM
|
Reply
OK, mofo. Here's a "mature" suggestion: The propensity for your comment indentation system to go tits up is now beyond Thunderdome. I would have thought you'd have written the code for it ages ago (because it has definitely worked in the past), and would be reusing that code each time you had to make changes. But every time you make a change it parps. Take the latest addition of comment sheathes as an example. Of course adding sheathes requires some modification to existing code, but nothing that changes the fact that a comment hierarchy is a TREE, with each node consisting of a COMMENT, together with a (possibly empty) list (in chronological order) of nodes for each reply to that comment. You must be capable of storing trees, and re-constructing trees from a stored representation. And you must have written code to take a comment tree and draw it on the screen. I don't see how adding comment sheathes should parp things up! And unless you've made some very recent adjustments I'm unaware of, the system is still happily malfunctioning like a massive nappy (http://www.poemranker.com/poem-details.
Replies:
Thanks. :)
Any better now?
I'm pretty sure the comment structure on that link I sent is now as it should be. I just pray your adjustments haven't introduced a myriad of other dumplings. Thanks!
My pleasure. I have hope for unmyriaded dumplings also much.
Then you should know all comments have reply buttons when I'm not logged in, but if I try to post a comment without logging in, I get a silly message.
could you give a url and the message for me to test?
It's any message. I'm currently logged out and looking at http://www.poemranker.com/poem-details.j
Look it isn't a bug. I think that's why nenwined doesn't know what you're talking about (why else would he have asked for a link?). Believe it or not, the system behaves as he intended it to - when you attempt to post a reply without logging in you get a message telling you to log in first. What you're suggesting is rewriting the comment system so Reply buttons do not appear unless you are logged in (in much the same way the 'Add a comment' box only appears when you are logged in). I hope I've clarified things - this slow motion suggestion thread was beginning to irritate me. -0-
I think instead of having sheathes, you should just start the comments out white and gradually make their background darker as the level of nesting increases. Having them reach black on black by about the tenth level of nesting would be about right I think; zodiac & dovina could always continue their conversations indefinitely if they wished by selecting the text to hilite and read it.
test
|